type of some table storage params on doc

From: Atsushi Torikoshi <atorik(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: type of some table storage params on doc
Date: 2020-03-16 02:07:37
Message-ID: CACZ0uYFf_p9BpbjLccx3CA=eM1Hk2Te=ULY4iptGLUhL-JxCPA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

As far as I read the reloptions.c, autovacuum_vacuum_cost_delay,
autovacuum_vacuum_scale_factor and autovacuum_analyze_scale_factor
are the members of relopt_real, so their type seems the same, real.

But the manual about storage parameters[1] says two of their type
are float4 and the other is floating point.

> autovacuum_vacuum_cost_delay, toast.autovacuum_vacuum_cost_delay
(floating point)
> autovacuum_vacuum_scale_factor, toast.autovacuum_vacuum_scale_factor
(float4)
> autovacuum_analyze_scale_factor (float4)

And the manual about GUC says all these parameters are floating
point.

> autovacuum_vacuum_cost_delay (floating point)
> autovacuum_vacuum_scale_factor (floating point)
> autovacuum_analyze_scale_factor (floating point)

Also other members of relopt_real such as seq_page_cost,
random_page_cost and vacuum_cleanup_index_scale_factor are
documented as floating point.

I think using float4 on storage parameters[1] are not consistent
so far, how about changing these parameters type from float4 to
floating point if there are no specific reasons using float4?

Attached a patch.
Any thought?

[1]https://www.postgresql.org/docs/devel/sql-createtable.htm
[2]https://www.postgresql.org/docs/devel/runtime-config-autovacuum.html

Regards,
--
Torikoshi Atsushi

Attachment Content-Type Size
fix_type_in_createtable_storage-params_v1.patch application/octet-stream 1.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-03-16 02:08:37 Re: comments on elements of xlogctldata
Previous Message Atsushi Torikoshi 2020-03-16 01:57:34 comments on elements of xlogctldata