Re: Proposal to include --exclude-extension Flag in pg_dump

Hi,
> long options should not mess with short options, does the following
> make sense to you?
Yes that makes sense, a reason to keep them together is that they are of
the same kind
But I will update the patch accordingly.

One more thing I wanted to ask is, Should I separate them in the
pg_dump.sgml file too? Like writing documentation of --exclude-extension
with other long options?

After your feedback I will update on both places in a single patch

Regards,
Ayush Vatsa
Amazon Web Services (AWS)

On Mon, 25 Dec 2023 at 16:28, Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:

> Hi
>
> On Mon, Dec 25, 2023 at 6:22 PM Ayush Vatsa <ayushvatsa1810(at)gmail(dot)com>
> wrote:
> >
> > Added a CF entry for the same https://commitfest.postgresql.org/46/4721/
> >
> > Regards
> > Ayush Vatsa
> > Amazon Web Services (AWS)
> >
> > On Mon, 25 Dec 2023 at 15:48, Ayush Vatsa <ayushvatsa1810(at)gmail(dot)com>
> wrote:
> >>
> >> Hi PostgreSQL Community,
> >> Recently I have been working on pg_dump regarding my project and wanted
> to exclude an extension from the dump generated. I wonder why it doesn't
> have --exclude-extension type of support whereas --extension exists!
> >> Since I needed that support, I took the initiative to contribute to the
> community by adding the --exclude-extension flag.
> >> Attached is the patch for the same. Looking forward to your feedback.
> >>
> >> Regards
> >> Ayush Vatsa
> >> Amazon Web services (AWS)
>
> printf(_(" -e, --extension=PATTERN dump the specified
> extension(s) only\n"));
> + printf(_(" --exclude-extension=PATTERN do NOT dump the specified
> extension(s)\n"));
> printf(_(" -E, --encoding=ENCODING dump the data in encoding
> ENCODING\n"));
>
> long options should not mess with short options, does the following
> make sense to you?
>
> printf(_(" --enable-row-security enable row security (dump only
> content user has\n"
> " access to)\n"));
> + printf(_(" --exclude-extension=PATTERN do NOT dump the specified
> extension(s)\n"));
> printf(_(" --exclude-table-and-children=PATTERN\n"
>
> --
> Regards
> Junwang Zhao
>