| From: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: copy-past-o comment in lock.h |
| Date: | 2019-05-08 07:59:36 |
| Message-ID: | CACPNZCvOUFf6WZAw0BMzXyW7ToZhuFf12i+dd29Yb_nAtitmEA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 8, 2019 at 3:10 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, May 07, 2019 at 04:12:31PM +0800, John Naylor wrote:
> > That's probably better.
>
> Would you like to send an updated patch? Perhaps you have a better
> idea?
> --
> Michael
In the attached, I've used your language, and also moved the comments
closer to the code they are describing. That seems more logical and
future proof.
--
John Naylor https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| locktag-comment-v2.patch | application/octet-stream | 4.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-05-08 08:03:31 | Re: copy-past-o comment in lock.h |
| Previous Message | Michael Paquier | 2019-05-08 07:58:53 | Re: Inconsistent error message wording for REINDEX CONCURRENTLY |