Re: Use compiler intrinsics for bit ops in hash

From: John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: Jesse Zhang <sbjesse(at)gmail(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use compiler intrinsics for bit ops in hash
Date: 2020-02-27 06:41:49
Message-ID: CACPNZCuvUN1cFKNHhqM-mZS2t-0N1ZQdn5pOeubtfj3ya1o61w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 27, 2020 at 1:56 PM David Fetter <david(at)fetter(dot)org> wrote:
> [v6 set]

Hi David,

In 0002, the pg_bitutils functions have a test (input > 0), and the
new callers ceil_log2_* and next_power_of_2_* have asserts. That seems
backward to me. I imagine some callers of bitutils will already know
the value > 0, and it's probably good to keep that branch out of the
lowest level functions. What do you think?

--
John Naylor https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-02-27 06:48:21 Re: [Patch] Make pg_checksums skip foreign tablespace directories
Previous Message Takuma Hoshiai 2020-02-27 06:35:00 Re: Incremental View Maintenance: ERROR: out of shared memory