From: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: copy-past-o comment in lock.h |
Date: | 2019-05-07 08:12:31 |
Message-ID: | CACPNZCt+bV8rpUjkgcMisttByKiFQ=8zdn1zXoS7g=zwsajErA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, May 7, 2019 at 4:00 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, May 07, 2019 at 03:41:50PM +0800, John Naylor wrote:
> > Attached is an attempt to match surrounding code. More broadly,
> > though, it seems the "ID info" comments belong with the SET_LOCKTAG_*
> > macros rather than with the LockTagType enum members.
>
> + LOCKTAG_SPECULATIVE_TOKEN, /* for speculative insertion */
> + /* ID info for a speculative token is TRANSACTION info + token */
> Shouldn't the first comment be just "speculative insertion"?
That's probably better.
> And the
> second one "ID info for a speculative insertion is transaction ID +
> its speculative insert counter"?
I was just going by the variable name at hand, but more precision may be good.
--
John Naylor https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Sergei Kornilov | 2019-05-07 08:13:15 | Re: New EXPLAIN option: ALL |
Previous Message | Amit Langote | 2019-05-07 08:10:34 | Re: BUG #15672: PostgreSQL 11.1/11.2 crashed after dropping a partition table |