| From: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: Avoid creation of the free space map for small tables |
| Date: | 2019-01-31 12:52:47 |
| Message-ID: | CACPNZCsJRwdst=V_W4wyU8_NL6PJpu2p_f6Et95eo_Zkw=mfnQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 31, 2019 at 1:43 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > I have an idea -- instead of adding a bunch of records and hoping that
> > the relation size and free space is consistent across platforms, how
> > about we revert to the original test input, and add a BRIN index? That
> > should have a FSM even with one record.
> >
>
> Why would BRIN index allow having FSM for heap relation?
Oops, I forgot this file is for testing heaps only. That said, we
could possibly put most of the FSM tests such as
SELECT * FROM fsm_page_contents(get_raw_page('test_rel_forks', 'fsm', 0));
into brin.sql since we know a non-empty BRIN index will have a FSM.
And in page.sql we could just have a test that the table has no FSM.
--
John Naylor https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-01-31 12:53:49 | Re: tab-completion debug print |
| Previous Message | Andres Freund | 2019-01-31 12:45:59 | Re: Reorganize collation lookup time and place |