| From: | Nicolas Adenis-Lamarre <nicolas(dot)adenis(dot)lamarre(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Planner : anti-join on left joins |
| Date: | 2026-01-01 22:28:01 |
| Message-ID: | CACPGbcu6ogMfuXDjte2i4Ffap9TDHb0qVKDRn+04q6_hbkOgdw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tender,
sorry, you patch is perfect. I badly tested it this morning. My fault.
There is just the case with the constant that is not handled (select *
from a left join (select 1 const1 from b) x where x.const1 is null)
but i don't think it worth handling it.
I added 2 regresssion tests in case you want to add them to your patch.
The first one is important, the second one is just to confirm that
subqueries are working.
I've added 3 new tables because in test_setup.sql and join.sql there
were no table with not null constraints.
Again, thanks a lot.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Reduce-JOIN_LEFT-TO-JOIN_ANTI-regression-tests.patch | text/x-patch | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nicolas Adenis-Lamarre | 2026-01-01 22:36:00 | Convert coalesce to or/and |
| Previous Message | Kirill Reshke | 2026-01-01 20:41:40 | Re: REASSIGN OWNED BY alters objects in other database. |