Re: Check for existing replication slot in pg_createsubscriber

From: Zane Duffield <duffieldzane(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Check for existing replication slot in pg_createsubscriber
Date: 2025-06-30 03:23:10
Message-ID: CACMiCkUDUz8ur++ACBvTMMUfPwkkD6n2dz-ng-SndRBLXXZsCQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 30, 2025 at 1:15 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:

> One thing I was
> thinking is whether it makes sense to add these checks only in
> --dry-run mode because we normally don't expect such conflicts.
> Otherwise, each such check adds an additional network round-trip.
>

I did wonder why it bothered checking for conflicts before running the
command that would fail in case of a conflict.
It makes sense to me to only check for conflicts in --dry-run mode.

Thanks,
Zane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2025-06-30 03:25:45 Re: Replace magic numbers with strategy numbers for B-tree indexes
Previous Message Daniil Davydov 2025-06-30 03:21:07 Replace magic numbers with strategy numbers for B-tree indexes