Re: [PATCH v2] Avoid internal error for invalid interval typmods

From: Feng Wu <wufengwufengwufeng(at)gmail(dot)com>
To: Haibo Yan <tristan(dot)yim(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH v2] Avoid internal error for invalid interval typmods
Date: 2026-07-01 01:49:30
Message-ID: CACK3muqtGkxD14bxbUL8wf1L3NVFpwky_-kxLkMw+ZK2T7757A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Haibo,

Thanks for reviewing.

I agree that the SQL-callable pg_catalog.interval(interval, int4) path is the
important case to cover here. The v1 test was already exercising that direct
call, but it used a DO block intentionally so that the regression test checks
the SQLSTATE is invalid_parameter_value, rather than only matching the error
message text.

In v2, I kept that structure and updated the test comment to make this clearer.

Regards,
Feng

Attachment Content-Type Size
v2-0001-Avoid-internal-error-for-invalid-interval-typmods.patch text/x-patch 3.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tender Wang 2026-07-01 01:49:31 Re: Fix HAVING-to-WHERE pushdown with mismatched operator families
Previous Message Guoqing Yang 2026-07-01 01:44:53 Fix Grammar in Buffer Lock Wait Message