Re: [PATCH v1] Fix for bug #19773 : pg_dump differing generation expressions of inherited columns

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: assam258(at)gmail(dot)com
Cc: Nitin Motiani <nitinmotiani(at)google(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH v1] Fix for bug #19773 : pg_dump differing generation expressions of inherited columns
Date: 2026-11-04 12:19:35
Message-ID: CACJufxHfKEw+tDiMjO4ONrO9fBXfmyqNpWs05VxXu9enst74Xw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 3, 2026 at 1:58 PM Henson Choi <assam258(at)gmail(dot)com> wrote:
>
> Hi Nitin,
>
> I have looked at v2. Below are my notes on the multi-parent scenario,
> and on how the backend problem where the restored child loses its
> inherited CHECK constraint shows up with v2.
>

Hi.

+ appendPQExpBuffer(q,
+ "ALTER %sTABLE ONLY %s ALTER COLUMN %s SET EXPRESSION AS (%s);\n",
+ foreign, qualrelname, fmtId(tbinfo->attnames[adnum - 1]),
+ adinfo->adef_expr);

ALTER COLUMN SET EXPRESSION
has some problems with dependencies, see [1] and [2]

[1]: https://www.postgresql.org/message-id/CACJufxEXY8O5rPLoieo1WoqbuO2ajCEJzVkXcykNtsyij8rEyA%40mail.gmail.com
[2]: https://www.postgresql.org/message-id/flat/CACJufxEomSz3BwUGfk8A6MeAKj%3DCki5B%2BgYTbJO%3DACCJyytWZg%40mail.gmail.com

--
jian
https://www.enterprisedb.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhijie Hou 2026-11-04 12:50:11 Re: Avoid resetting subscription two_phase state to pending when already enabled
Previous Message Raja Sai pranav 2026-11-04 11:56:17 Re: Re: [PATCH] Fix use-after-free after failed pg_checksum_init