Re: Fix bug of CHECK constraint enforceability recursion

Hi.

I did some refactoring based on your v3, I didn't change your comments.

I don't think ATGetEquivalentCheckConstraintOid is necessary.
ATCheckCheckConstrHasEnforcedParent,
AlterCheckConstrEnforceabilityRecurse is enough for this context.

+ changing_conids = lappend_oid(list_copy(changing_conids),
+ currcon->oid);
Refactor changing_conids to List ** to allow direct modification,
aligning with existing code conventions.

CREATE TABLE ... PARTITION OF automatically copies the parent's status, and
ALTER TABLE ... ATTACH PARTITION already rejects cases where the parent is
enforced but the child is not. If we also reject directly altering a partition's
constraint enforcement status, then we need no longer worry about cases where
parent being enforced while a child is not. Therefore, invoking
ATCheckCheckConstrHasEnforcedParent just once for table partitioning is safe.

--
jian
https://www.enterprisedb.com/