| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: remaining sql/json patches |
| Date: | 2023-11-17 07:27:22 |
| Message-ID: | CACJufxH2=pqxGbRd1RQ1TdL2XFAM2dfEi8bffLu=OWwq9m0GOA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
hi.
minor issues.
In transformJsonFuncExpr(ParseState *pstate, JsonFuncExpr *func)
func.behavior->on_empty->location and
func.behavior->on_error->location are correct.
but in ExecInitJsonExpr, jsestate->jsexpr->on_empty->location is -1,
jsestate->jsexpr->on_error->location is -1.
Maybe we can preserve these on_empty, on_error token locations in
transformJsonBehavior.
some enum declaration, ending element need an extra comma?
+ /*
+ * ExecEvalJsonExprPath() will set this to the address of the step to
+ * use to coerce the result of JsonPath* evaluation to the RETURNING
+ * type. Also see the description of possible step addresses this
+ * could be set to in the definition of JsonExprState.ZZ
+ */
"ZZ", typo?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2023-11-17 07:39:03 | Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock |
| Previous Message | jian he | 2023-11-17 07:12:30 | Re: SQL:2011 application time |