Re: MERGE ... RETURNING

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: walther(at)technowledgy(dot)de, Jeff Davis <pgsql(at)j-davis(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, Gurjeet Singh <gurjeet(at)singh(dot)im>, Isaac Morland <isaac(dot)morland(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: MERGE ... RETURNING
Date: 2024-03-13 06:44:12
Message-ID: CACJufxGynyk=T0wi9FBdZ45aPT62uYkfh0-2PYVP_ziD5BdKJQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, some minor issues:

<synopsis>
[ WITH <replaceable class="parameter">with_query</replaceable> [, ...] ]
MERGE INTO [ ONLY ] <replaceable
class="parameter">target_table_name</replaceable> [ * ] [ [ AS ]
<replaceable class="parameter">target_alias</replaceable> ]
USING <replaceable class="parameter">data_source</replaceable> ON
<replaceable class="parameter">join_condition</replaceable>
<replaceable class="parameter">when_clause</replaceable> [...]
[ RETURNING * | <replaceable
class="parameter">output_expression</replaceable> [ [ AS ]
<replaceable class="parameter">output_name</replaceable> ] [, ...] ]

here the "WITH" part should have "[ RECURSIVE ]" like:
[ WITH [ RECURSIVE ] <replaceable
class="parameter">with_query</replaceable> [, ...] ]

+ An expression to be computed and returned by the <command>MERGE</command>
+ command after each row is merged. The expression can use any columns of
+ the source or target tables, or the <xref linkend="merge_action"/>
+ function to return additional information about the action executed.
+ </para>
should be:
+ An expression to be computed and returned by the <command>MERGE</command>
+ command after each row is changed.

one minor issue:
add
`
table sq_target;
table sq_source;
`
before `-- RETURNING` in src/test/regress/sql/merge.sql, so we can
easily understand the tests.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2024-03-13 06:45:26 Re: Disable LLVM bitcode generation with pgxs.mk framework.
Previous Message Andrew Dunstan 2024-03-13 06:42:31 Re: meson vs tarballs