Re: [PATCH] Add planner support function to two-argument regexp_like()

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: shihao zhong <zhong950419(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Add planner support function to two-argument regexp_like()
Date: 2026-10-04 06:47:09
Message-ID: CACJufxGiA4FYOqveLLkYg0OtwUrHK_+iUwWLQoPk_JeTffXT2g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 29, 2026 at 12:11 PM shihao zhong <zhong950419(at)gmail(dot)com> wrote:
>
> Hi hackers,
>
> The ~ operator gets index conditions from a fixed pattern prefix, via
> textregexeq_support(). regexp_like(), which is the same test, has no
> support function and so misses out.
>
> With no flags the two are identical,

regexp_like_no_flags is the same as textregexeq,
therefore let the textregexeq support function also used in
regexp_like_no_flags is OK, i think.

we already have coverage for textregexeq_support,
https://coverage.postgresql.org/src/backend/utils/adt/like_support.c.gcov.html.
I tend to think V1 regression tests are unnecessary, but that's a minor point.

--
jian
https://www.enterprisedb.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2026-10-04 07:23:04 Re: ERROR: no relation entry for relid 3
Previous Message Bertrand Drouvot 2026-10-04 06:23:20 Re: Report relation extension blockers within parallel lock groups