| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: speedup COPY TO for partitioned table. |
| Date: | 2025-10-06 09:48:53 |
| Message-ID: | CACJufxGh8Nh=AwXNFgatgCmD3W0P6-HbEwAHTHaz0Lwegbr2Ng@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 3, 2025 at 8:31 AM torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> wrote:
>
> It’s been about two months since this discussion, and there don’t seem
> to be any further comments.
> How about updating the patch accordingly?
> If there are no new remarks, I’d like to mark the patch as Ready for
> Committer.
>
> >> + List *children = NIL;
> >> ...
> >> + {
> >> + children = find_all_inheritors(RelationGetRelid(rel),
> >>
> >> Since 'children' is only used inside the else if block, I think we
> >> don't
> >> need the separate "List *children = NIL;" declaration.
> >> Instead, it could just be "List *children =
> >> find_all_inheritors(...)".
> >>
> > you are right.
> > ""List *children = find_all_inheritors(...)"." should be ok.
>
hi.
please check the attached v15.
only minor adjustment based on comments in
https://postgr.es/m/c507919d8c8219ab6cfd8376a4f9a887@oss.nttdata.com
| Attachment | Content-Type | Size |
|---|---|---|
| v15-0001-support-COPY-partitioned_table-TO.patch | text/x-patch | 12.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Filip Janus | 2025-10-06 09:58:59 | Re: [PATCH] Better Performance for PostgreSQL with large INSERTs |
| Previous Message | Tatsuo Ishii | 2025-10-06 09:34:39 | Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options |