| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_restore --no-policies should not restore policies' comment |
| Date: | 2025-08-27 06:17:41 |
| Message-ID: | CACJufxGbCFdTnuaHOJe463UCnE-WE6XNRdE4dNSZrpKMyoagkQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 26, 2025 at 7:43 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> >
> > summary of attached patch:
>
> Thanks for the patches!
>
> > 01: make pg_restore not restore comments if comments associated
> > objects are excluded.
>
> > TODO: need perl tests
>
> How about adding tests for pg_restore --no-policies in 002_pg_dump.pl,
> as in the attached patch?
>
it works fine on my local linux machine.
> Since --no-publications and --no-subscriptions have been around for a long time,
> while --no-policies was added in v18, I wonder if it makes sense to first fix
> the publications and subscriptions cases (and add tests for them) and back-patch
> to all supported versions. Then we can handle the policies case and
> back-patch it
> only to v18. Does that sound reasonable?
>
works for me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2025-08-27 06:41:36 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |
| Previous Message | Antonin Houska | 2025-08-27 06:16:07 | Re: Adding REPACK [concurrently] |