From: | jian he <jian(dot)universality(at)gmail(dot)com> |
---|---|
To: | Jiří Kavalík <jkavalik(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] Support for basic ALTER TABLE progress reporting. |
Date: | 2025-07-08 13:42:07 |
Message-ID: | CACJufxGNY77EtPQjU+MsAjaO-Uto-sLnJg55ePLMr6JFc6MH+w@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
hi.
within ATRewriteTable we have:
pgstat_progress_update_param(PROGRESS_CLUSTER_TOTAL_HEAP_BLKS,
RelationGetNumberOfBlocks(oldrel));
pgstat_progress_update_param(PROGRESS_CLUSTER_TOTAL_HEAP_BLKS,
heapScan->rs_nblocks);
PROGRESS_CLUSTER_TOTAL_HEAP_BLKS
value is fixed, we only need to call pgstat_progress_update_param once here?
another patch [1] is expected to refactor pg_stat_progress_cluster a lot, so I'm
unsure whether it's a good idea to put CLUSTER, VACUUM FULL, or ALTER TABLE into
pg_stat_progress_cluster.
alternatively, we could introduce a separate progress report specifically for
ALTER TABLE, allowing us to distinguish between table rewrite and table
scan.
From | Date | Subject | |
---|---|---|---|
Next Message | Ashutosh Bapat | 2025-07-08 13:59:12 | Re: Using failover slots for PG-non_PG logical replication |
Previous Message | Tomas Vondra | 2025-07-08 13:21:04 | Re: amcheck support for BRIN indexes |