minor error message inconsistency in make_pathkey_from_sortinfo

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: minor error message inconsistency in make_pathkey_from_sortinfo
Date: 2024-04-24 07:05:00
Message-ID: CACJufxGNJqR79WEwBRw9g2DB-6WhNcJs1uuG7KnTGA5ouM6eug@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

hi.

in make_pathkey_from_sortinfo

equality_op = get_opfamily_member(opfamily,
opcintype,
opcintype,
BTEqualStrategyNumber);
if (!OidIsValid(equality_op)) /* shouldn't happen */
elog(ERROR, "missing operator %d(%u,%u) in opfamily %u",
BTEqualStrategyNumber, opcintype, opcintype, opfamily);

the error message seems not right?

maybe
if (!OidIsValid(equality_op)) /* shouldn't happen */
elog(ERROR, "missing operator =(%u,%u) in opfamily %u",opcintype,
opcintype, opfamily);

or

if (!OidIsValid(equality_op)) /* shouldn't happen */
elog(ERROR, "missing equality operator for type %u in opfamily
%u",opcintype, opcintype, opfamily);

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-04-24 07:17:44 Partitioned tables and [un]loggedness
Previous Message Jakub Wartak 2024-04-24 06:57:55 Re: GUC-ify walsender MAX_SEND_SIZE constant