| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: code cleanup for CREATE STATISTICS |
| Date: | 2025-11-13 03:44:38 |
| Message-ID: | CACJufxG2WWXayNdtc88VZgqVbd6+z=HXKX=WxMw2+uJUQUHT4w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 3, 2023 at 1:50 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> Hi,
>
> So the attached patch is proposed as code cleanup, rather than
> security patches. It changes the code to avoid the duplicate name
> lookup altogether. There is no reason that I know of why this needs to
> be back-patched for correctness, but I think it's worth putting into
> master to make the code nicer and avoid doing things that in some
> circumstances can be risky.
>
hi.
while working on
https://commitfest.postgresql.org/patch/6106
Somehow, I accidentally found this thread by searching on gmail (web).
I copied most of your patch (more than 50%) and posted it on that thread....
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-11-13 03:44:45 | Re: misleading error message in ProcessUtilitySlow T_CreateStatsStmt |
| Previous Message | Amit Kapila | 2025-11-13 03:42:36 | Re: Rename sync_error_count to tbl_sync_error_count in subscription statistics |