| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: bug, ALTER TABLE call ATPostAlterTypeCleanup twice for the same relation |
| Date: | 2025-09-27 14:23:59 |
| Message-ID: | CACJufxG1Qwj=mHHZNT6L=7g9MeizbD3B+1=HN1TDvv4M92pTEQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Sep 27, 2025 at 5:54 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> While at it, maybe we can also polish the comment below in ATRewriteCatalogs.
> /*
> * After the ALTER TYPE or SET EXPRESSION pass, do cleanup work
> * (this is not done in ATExecAlterColumnType since it should be
> * done only once if multiple columns of a table are altered).
> */
> but I didn't do it...
I add one sentence:
Note: ATPostAlterTypeCleanup must be called only once per relation!
I also polished the regress tests.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-ALTER-TABLE-each-relation-call-ATPostAlterTypeCleanup.patch | text/x-patch | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-09-27 15:23:28 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Greg Burd | 2025-09-27 14:03:14 | Re: [PATCH] Add tests for Bitmapset |