finish TODOs in to_json_is_immutable, to_jsonb_is_immutable also add tests on it

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: finish TODOs in to_json_is_immutable, to_jsonb_is_immutable also add tests on it
Date: 2025-05-19 01:09:18
Message-ID: CACJufxFz=OsXQdsMJ-cqoqspD9aJrwntsQP-U2A-UaV_M+-S9g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

hi.

somehow, I accidentally saw the TODOs (commits [3]) on jsonb.c and json.c
for functions: to_json_is_immutable and to_jsonb_is_immutable.
The attached patch is to finalize these TODOs.

per coverage [1], [2], there was zero coverage for these two functions.
so I also added extensive tests on it.

[1] https://coverage.postgresql.org/src/backend/utils/adt/jsonb.c.gcov.html
[2] https://coverage.postgresql.org/src/backend/utils/adt/json.c.gcov.html
[3] https://git.postgresql.org/cgit/postgresql.git/commit/?id=7081ac46ace8c459966174400b53418683c9fe5c

Attachment Content-Type Size
v1-0001-enhance-json_array-json_object-expression-is-immutable-or.patch text/x-patch 25.3 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-05-19 01:52:15 Re: Statistics Import and Export
Previous Message Michael Paquier 2025-05-18 23:48:00 Re: Suggestion: Update Copyright Year to 2025 in Recently Added Files