| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tomas Vondra <tomas(at)vondra(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Subject: | Re: Extended Statistics set/restore/clear functions. |
| Date: | 2025-11-13 07:01:42 |
| Message-ID: | CACJufxFo5b0FvmV4CmOb74NFrXm_znZHh7bLiiVkAzVzTnJiVw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
hi.
v12-0001 and v12-0002 overall look good to me.
if (dependency->nattributes <= 1)
elog(ERROR, "invalid zero-length nattributes array in
MVDependencies");
This is an unlikely-to-happen error message, but still, “nattributes”
seems confusing?
in doc/src/sgml/func/func-json.sgml, we have \gset
<programlisting>
SELECT '{
.......
}
}' AS json \gset
</programlisting>
similarly, in doc/src/sgml/perform.sgml, I think the query should be:
SELECT stxkeys AS k, jsonb_pretty(stxdndistinct::text::jsonb) AS nd
FROM pg_statistic_ext join pg_statistic_ext_data on (oid = stxoid)
WHERE stxname = 'stts2' \gx
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-11-13 07:02:20 | Re: [WIP]Vertical Clustered Index (columnar store extension) - take2 |
| Previous Message | Chao Li | 2025-11-13 06:54:28 | Re: Suggestion to add --continue-client-on-abort option to pgbench |