| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Kim Johan Andersson <kimjand(at)kimmet(dot)dk>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Add support function for containment operators |
| Date: | 2024-01-17 04:39:36 |
| Message-ID: | CACJufxFh9Ln7KQWdzbnjSVfvJTbLwZLkSHvD+rSfPyt8ohu+=w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 17, 2024 at 5:46 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> But perhaps someone has an argument for a different rule?
>
> Anyway, pending discussion of that point, I think the code is good
> to go. I don't like the test cases much though: they expend many more
> cycles than necessary. You could prove the same points just by
> looking at the expansion of expressions, eg.
>
your patch is far better!
IMHO, worried about the support function, the transformed plan
generates the wrong result,
so we add the tests to make it bullet proof.
Now I see your point. If the transformed plan is right, the whole
added code should be fine.
but keeping the textrange_supp related test should be a good idea.
since we don't have SUBTYPE_OPCLASS related sql tests.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nisha Moond | 2024-01-17 04:43:17 | Re: Improve the connection failure error messages |
| Previous Message | Peter Smith | 2024-01-17 04:37:14 | Re: Synchronizing slots from primary to standby |