| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: DELETE/UPDATE FOR PORTION OF with rule system is not working |
| Date: | 2026-04-17 03:20:08 |
| Message-ID: | CACJufxFSTwzJxFYwD5mb5hSj9CvZxBh500Sza0CKoFCxB6iLsg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 16, 2026 at 6:40 AM Paul A Jungwirth
<pj(at)illuminatedcomputing(dot)com> wrote:
>
> I only have two small suggestions:
>
> Please use '[1, 11)' syntax to match the other tests.
>
> Breaking these long lines would be nice. For example:
>
> +CREATE RULE fpo_rule1 AS ON INSERT TO fpo_rule
> + DO INSTEAD UPDATE fpo_rule FOR PORTION OF f2 FROM 1 TO 4 SET f1 = 2;
>
Please check the attached v2.
V1 only has DO INSTEAD rules, adding one DO ALSO rule would make the
test coverage more robust.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-fix-DELETE-UPDATE-FOR-PORTION-OF-with-rules.patch | text/x-patch | 5.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2026-04-17 03:30:59 | Re: Reject invalid databases in pg_get_database_ddl() |
| Previous Message | Zhijie Hou (Fujitsu) | 2026-04-17 03:01:08 | Fix stats reporting delays in logical parallel apply worker |