stale comment in struct AlteredTableInfo

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: stale comment in struct AlteredTableInfo
Date: 2026-09-23 03:02:33
Message-ID: CACJufxEvw496SK=nmvxOL0SQYBPhrsnad1DUj6cPs17cvvDSMQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

HI.

{
/* Objects to rebuild after completing ALTER TYPE operations */
List *changedConstraintOids; /* OIDs of constraints to rebuild */
List *changedConstraintDefs; /* string definitions of same */
List *changedIndexOids; /* OIDs of indexes to rebuild */
List *changedIndexDefs; /* string definitions of same */
char *replicaIdentityIndex; /* index to reset as REPLICA IDENTITY */
char *clusterOnIndex; /* index to use for CLUSTER */
List *changedStatisticsOids; /* OIDs of statistics to rebuild */
List *changedStatisticsDefs; /* string definitions of same */
List *changedStatisticsOwners; /* owners of same */
} AlteredTableInfo;

Comment
/* Objects to rebuild after completing ALTER TYPE operations */
should be
/* Objects to rebuild after completing ALTER TYPE or SET EXPRESSION
operations */

Since these objects apply to ALTER COLUMN SET EXPRESSION too.

--
jian
https://www.enterprisedb.com/

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2026-09-23 03:22:40 Re: Add a permission check to pg_stat_get_backend_subxact()
Previous Message Khoa Nguyen 2026-09-23 02:20:22 Re: HASH INDEX builds seems confused