| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru> |
| Cc: | Junwang Zhao <zhjwpku(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Date: | 2025-06-12 11:03:13 |
| Message-ID: | CACJufxEvPf7__DRJ8HRrxBk=iNN+dDXrQTTj=pB5N2=ZvnC_BA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
hi.
one more minor issue.
+ * defaultPart: true if one of split partitions is DEFAULT
+ * pstate: pointer to ParseState struct for determining error position
+ */
+static void
+check_two_partitions_bounds_range(Relation parent,
+ RangeVar *first_name,
+ PartitionBoundSpec *first_bound,
+ RangeVar *second_name,
+ PartitionBoundSpec *second_bound,
+ bool defaultPart,
+ ParseState *pstate)
v43-0001 doesn't have the SPLIT PARTITION feature.
maybe we need to remove the argument (bool defaultPart)
from check_two_partitions_bounds_range, aslo remove the comments.
then we can add it on 0002 SPLIT PARTITION patch.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-06-12 11:24:36 | Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly |
| Previous Message | shveta malik | 2025-06-12 10:52:12 | Re: Conflict detection for update_deleted in logical replication |