From: | jian he <jian(dot)universality(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Propagate sanity checks of ProcessUtility() to standard_ProcessUtility()? |
Date: | 2024-02-29 08:10:26 |
Message-ID: | CACJufxENjwgKUuv_Na72W5OmYEq1ycZ5s7Rd8kXPk-XDK3sh6g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Feb 29, 2024 at 3:21 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> Hi all,
>
> It's been brought to me that an extension may finish by breaking the
> assumptions ProcessUtility() relies on when calling
> standard_ProcessUtility(), causing breakages when passing down data to
> cascading utility hooks.
>
> Isn't the state of the arguments given something we should check not
> only in the main entry point ProcessUtility() but also in
> standard_ProcessUtility(), to prevent issues if an extension
> incorrectly manipulates the arguments it needs to pass down to other
> modules that use the utility hook, like using a NULL query string?
>
> See the attached for the idea.
why not just shovel these to standard_ProcessUtility.
so ProcessUtility will looking consistent with (in format)
* ExecutorStart()
* ExecutorRun()
* ExecutorFinish()
* ExecutorEnd()
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Banck | 2024-02-29 08:13:04 | Remove AIX Support (was: Re: Relation bulk write facility) |
Previous Message | Michael Paquier | 2024-02-29 07:20:53 | Propagate sanity checks of ProcessUtility() to standard_ProcessUtility()? |