Re: pg_dump does not dump domain not-null constraint's comments

On Wed, May 7, 2025 at 10:56 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> Ooh, you know what? I ran your the CREATE DOMAIN statement in your new
> test and pg_dump'ed that, and as far as I can tell the _name_ of the
> not-null constraint is not dumped either. So it's not just the comment
> that we're losing. That's a separate bug, and probably needs to be
> fixed first, although I'm not sure if that one is going to be
> back-patchable. Which means, I withdraw my earlier assessment that the
> comment fix is back-patchable as a whole.
>

for PG17. we change the dump of
create domain test.d4 as int constraint nn not null;
from
CREATE DOMAIN test.d4 AS integer NOT NULL;
to
CREATE DOMAIN test.d4 AS integer CONSTRAINT nn NOT NULL;

in PG17 we didn't preserve the constraint name, now if we did, then
it's a bug fix,
so it can be back-patchable?

Anyway, the attachment is for PG18 only now, it will fix the domain constraint
name loss and domain not-null comments loss issue together.