Re: Add pg_basetype() function to obtain a DOMAIN base type

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, John Naylor <johncnaylorls(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Steve Chavez <steve(at)supabase(dot)io>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add pg_basetype() function to obtain a DOMAIN base type
Date: 2024-03-18 00:00:00
Message-ID: CACJufxEGe6w6RKE4T18OoQ=0JCRCRgL4W-g_Dau5scZFR2axNQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

looking at it again.
I found out we can just simply do
`
Datum
pg_basetype(PG_FUNCTION_ARGS)
{
Oid oid;

oid = get_fn_expr_argtype(fcinfo->flinfo, 0);
PG_RETURN_OID(getBaseType(oid));
}
`

if the type is not a domain, work the same as pg_typeof.
if the type is domain, pg_typeof return as is, pg_basetype return the
base type.
so it only diverges when the argument type is a type of domain.

the doc:
<function>pg_basetype</function> ( <type>"any"</type> )
<returnvalue>regtype</returnvalue>
</para>
<para>
Returns the OID of the base type of a domain. If the argument
is not a type of domain,
return the OID of the data type of the argument just like <link
linkend="function-pg-typeof"><function>pg_typeof()</function></link>.
If there's a chain of domain dependencies, it will recurse
until finding the base type.
</para>

also, I think this way, we only do one syscache lookup.

Attachment Content-Type Size
v4-0001-Add-pg_basetype-any-function-for-querying-basetyp.patch application/x-patch 6.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Wienhold 2024-03-18 00:09:50 Re: Q: Escapes in jsonpath Idents
Previous Message Daniel Gustafsson 2024-03-17 23:49:24 Re: Support json_errdetail in FRONTEND builds