| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Quan Zongliang <quanzongliang(at)yeah(dot)net> |
| Cc: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Remove dead code in ExecForPortionOfLeftovers() |
| Date: | 2026-04-22 04:24:08 |
| Message-ID: | CACJufxE7cpK_eY+HXVFD_DBfMpRxCUoHfZBKRYLwgKW2NB8=Rw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 22, 2026 at 11:58 AM Quan Zongliang <quanzongliang(at)yeah(dot)net> wrote:
>
>
> On 4/21/26 8:22 PM, Aleksander Alekseev wrote:
> > Hi,
> >
> > While reading 8e72d914c528 I noticed that
> > ForPortionOfState.fp_leftoverstypcache is not used for anything. I
> > suggest removing it, as attached.
> >
>
> Agree.
> It indeed did not make any reference anywhere.
>
I raised this issue at [1].
But apparently, it's actually being used for fixing a bug at [2].
[1]: https://www.postgresql.org/message-id/CACJufxHYntqy2fo9CFWDDrqKjcMK8DGRM3kse4YnXYnPYq2Hiw%40mail.gmail.com
[2]: https://www.postgresql.org/message-id/CA%2BrenyU5%3Dmihx6O8%2BERBmarZcuV1QiWB3X5bZhdptWoRM9G-Aw%40mail.gmail.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nishant Sharma | 2026-04-22 04:27:00 | Re: [BUG] CRASH: ECPGprepared_statement() and ECPGdeallocate_all() when connection is NULL |
| Previous Message | Amit Langote | 2026-04-22 04:04:17 | Re: Eliminating SPI / SQL from some RI triggers - take 3 |