Re: regdatabase

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: regdatabase
Date: 2025-05-19 02:37:29
Message-ID: CACJufxE5eirUB330vyVVrNPxEHqRNn8e353xVVF70yUpR5XcvA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 8, 2025 at 11:20 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Thu, May 08, 2025 at 10:38:04PM +0900, Ian Lawrence Barwick wrote:
> > Revised patch attached which adds coverage of that and also for the
> > "constant of the type reg(role|database) cannot be used here" error.
>
> LGTM. I've marked it as ready-for-committer [0] and will plan on
> committing it as soon as v19 development begins.
>
> [0] https://commitfest.postgresql.org/patch/5746/
>

hi.

I saw REGROLEOID in foreign_expr_walker,
I'm wondering whether REGDATABASEOID is reachable within foreign_expr_walker.

not familiar with this area, also there are no coverage tests for
other reg*Const,
per
https://coverage.postgresql.org/contrib/postgres_fdw/deparse.c.gcov.html

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robins Tharakan 2025-05-19 03:19:26 Re: wrong query results on bf leafhopper
Previous Message Michael Paquier 2025-05-19 01:52:15 Re: Statistics Import and Export