| From: | Максим Орлов <orlovmg(at)gmail(dot)com> |
|---|---|
| To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
| Cc: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>, Maxim Orlov <m(dot)orlov(at)postgrespro(dot)ru>, lubennikovaav(at)gmail(dot)com |
| Subject: | Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. |
| Date: | 2021-12-23 18:05:47 |
| Message-ID: | CACG=ezZYRH6u5a642_TC+LidT8UKACN+UU48B07ioJFnZ5aOtA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> The pstrdup is unnecessary but harmless.
>
> > - use the existing table for uniqueness check in 005_opclass_damage.pl
>
> It appears you still create a new table, bttest_unique, rather than using
> the existing table int4tbl. That's fine.
>
> > - added tests into 003_check.pl . It is only smoke test that just
> verifies new functions.
>
> You have borrowed the existing tests but forgot to change their names.
> (The last line of each check is the test name, such as 'pg_amcheck smoke
> test --parent-check'.) Please make each test name unique.
>
Thanks for your review! Fixed all these remaining things from patch v6.
PFA v7 patch.
---
Best regards,
Maxim Orlov.
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Add-option-for-amcheck-and-pg_amcheck-to-check-un.patch | application/octet-stream | 42.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2021-12-23 18:50:22 | Re: sequences vs. synchronous replication |
| Previous Message | Andrew Dunstan | 2021-12-23 17:58:49 | Re: Buildfarm support for older versions |