| From: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Ivan Bykov <i(dot)bykov(at)modernsys(dot)ru>, Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Subject: | Re: IPC/MultixactCreation on the Standby server |
| Date: | 2025-12-05 16:36:20 |
| Message-ID: | CACG=ezbtm+LOzEMyLX7rzGcAv3ez3F6nNpSJjvZeMzed0Oe6Pw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 28 Nov 2025 at 22:51, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> I moved the wraparound test to a separate test file and commit. More
> test coverage is good, but it's quite separate from the bugfix and the
> wraparound related test shares very little with the other test. The
> wraparound test needs a little more cleanup: use plain perl instead of
> 'dd' and 'rm' for the file operations, for example. (I did that with the
> tests in the 64-bit mxoff patches, so we could copy from there.)
>
> It's good that the test was added. But it seems like it could be
improved a bit. The problem is, it only runs successfully with a
standard block size. Plus, the comment about the number of bytes was a
bit unclear, for my taste. PFA patch, it should make this test pass
with different block sizes.
--
Best regards,
Maxim Orlov.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Improve-7b81be9b42-Add-test-for-multixid-wraparound.patch | application/octet-stream | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2025-12-05 16:38:03 | Re: commented out code |
| Previous Message | Tom Lane | 2025-12-05 16:20:50 | Re: More const-marking cleanup |