| From: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
|---|---|
| To: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Custom tuplesorts for extensions |
| Date: | 2022-06-23 12:12:27 |
| Message-ID: | CACG=ezbWfphJQkttNDyFy4jihOz+YkYRp5KT21+7QrRmkEUhbQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
I've reviewed the patchset and noticed some minor issues:
- extra semicolon in macro (lead to warnings)
- comparison of var isWorker should be done in different way
Here is an upgraded version of the patchset.
Overall, I consider this patchset useful. Any opinions?
--
Best regards,
Maxim Orlov.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0005-Reorganize-data-structures.patch | text/x-patch | 66.1 KB |
| v2-0004-Move-freeing-memory-away-from-writetup.patch | text/x-patch | 6.9 KB |
| v2-0006-Split-tuplesortops.c.patch | text/x-patch | 112.9 KB |
| v2-0002-Tuplesortstate.getdatum1-method.patch | text/x-patch | 7.6 KB |
| v2-0001-Remove-Tuplesortstate.copytup.patch | text/x-patch | 16.4 KB |
| v2-0003-Put-abbreviation-logic-into-puttuple_common.patch | text/x-patch | 9.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Malakhov | 2022-06-23 12:31:14 | TOAST - moving Compression into Toast for oversized Tuples |
| Previous Message | Przemysław Sztoch | 2022-06-23 12:10:42 | Re: [PATCH] Completed unaccent dictionary with many missing characters |