| From: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, wenhui qiu <qiuwenhuifx(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: POC: make mxidoff 64 bits |
| Date: | 2025-12-11 12:47:53 |
| Message-ID: | CACG=ezaVcG-uoD+U1D-6ELe3H5zqQM0CsC5ts6yA_u=553+EXg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 11 Dec 2025 at 10:58, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> That's a great question and I've been wondering about it myself. It goes
> all the way to the initial commit where multixacts were introduced, and
> I don't see any particular reason for it even back then. Even in the
> very first version of multixact.c, IMO it would've been simpler to have
> the writer handle the wraparound.
>
> +1 This code is quite old. I don't see any particular reason for doing
it that way. Unfortunately, we were unable to prove the absence of
something, namely errors, in this instance. But there were no obvious
statements on why it should be in this manner. So, for me, it's much
clearer to increment and handle wraparound in one place rather
than spread it across multiple calls in the module.
--
Best regards,
Maxim Orlov.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-12-11 12:56:03 | regex Quantifiers {m,n}, m can be negative, n greater than 255 |
| Previous Message | Tomas Vondra | 2025-12-11 12:46:54 | Re: failed NUMA pages inquiry status: Operation not permitted |