From: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
---|---|
To: | ls7777 <ls7777(at)yandex(dot)ru> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch for migration of the pg_commit_ts directory |
Date: | 2025-09-30 10:35:26 |
Message-ID: | CACG=eza020LBv6-PPHFTi8OET1971bi8on98Uw6AtW7yV=eX+g@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Yes, the pg_commit_ts directory is not transferred by pg_upgrade.
Basically, you can get the exact same result by manually copying the
pg_commit_ts directory and running pg_resetwal. And this patch does it
automatically.
In other words, the patch provides the stated functionality, but
consider running pgindet.
I'm not sure whether there were any reasons not to make this move from
the beginning. The authors' opinions are needed here.
And one more thing. In my perspective, having some tests is always a
good idea, even if they are not meant to be committed. After briefly
examining the patch, I developed this basic test. This is not finalized
in any manner, but it is simply an idea.
--
Best regards,
Maxim Orlov.
Attachment | Content-Type | Size |
---|---|---|
006_commit_ts.pl.txt | text/plain | 2.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Álvaro Herrera | 2025-09-30 11:16:50 | Re: allow benign typedef redefinitions (C11) |
Previous Message | David Rowley | 2025-09-30 10:29:36 | Re: [PATCH] Add tests for Bitmapset |