From: | "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de> |
---|---|
To: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
Cc: | David Steele <david(at)pgmasters(dot)net>, Scott Mead <scottm(at)openscg(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_hba_lookup function to get all matching pg_hba.conf entries |
Date: | 2016-03-17 07:56:33 |
Message-ID: | CACACo5StSvRuhNU0x06zu69U00CX3gOFZN=HvN-SzdHzTuZAzg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Mar 17, 2016 at 2:12 AM, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
wrote:
> On Wed, Mar 16, 2016 at 9:49 PM, Shulgin, Oleksandr
> <oleksandr(dot)shulgin(at)zalando(dot)de> wrote:
> >
> > Some comments:
> >
> > +/* Context to use with hba_line_callback function. */
> > +typedef struct
> > +{
> > + MemoryContext memcxt;
> > + TupleDesc tupdesc;
> > + Tuplestorestate *tuple_store;
> > +} HbalineContext;
> >
> > Rather "with *lookup_hba_line_callback*", as hba_line_callback() is a
> > generic one.
>
> Fine. I will change the function and context names.
>
You mean change context name and correct the comment? I didn't suggest to
change the function name.
> Still remains an issue of representing special keywords in database and
> > user_name fields, but there was no consensus about that though.
>
> How about adding keyword_database and keyword_user columns to listing
> out the keywords. These columns will be populated only when the hba line
> contains any keywords.
>
Hm... that could work too.
--
Alex
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Jelinek | 2016-03-17 07:56:49 | Re: WIP: Access method extendability |
Previous Message | Amit Kapila | 2016-03-17 07:51:32 | Re: [WIP] speeding up GIN build with parallel workers |