| From: | "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de> |
|---|---|
| To: | Tomasz Rybak <tomasz(dot)rybak(at)post(dot)pl>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: pglogical_output - a general purpose logical decoding output plugin |
| Date: | 2016-01-04 17:25:00 |
| Message-ID: | CACACo5Q2GBjzVW4H4hjDRny2-yKzJx-sVT-+gtHaOcK2TV3z0g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 3, 2016 at 7:21 PM, Tomasz Rybak <tomasz(dot)rybak(at)post(dot)pl> wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: not tested
> Spec compliant: not tested
> Documentation: tested, failed
>
> Applies cleanly on current master
> (b416c0bb622ce5d33fdbec3bbce00451132f10ec).
>
> Builds without any problems on current Debian unstable (am64 arch, GCC
> 5.3.1-4, glibc 2.21-6)
>
A make from an external build dir fails on install, suggested fix:
install: all
$(MKDIR_P) '$(DESTDIR)$(includedir)'/pglogical_output
- $(INSTALL_DATA) pglogical_output/hooks.h
'$(DESTDIR)$(includedir)'/pglogical_output
+ $(INSTALL_DATA)
$(top_srcdir)/contrib/pglogical_output/pglogical_output/hooks.h
'$(DESTDIR)$(includedir)'/pglogical_output
--
Alex
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2016-01-04 17:27:03 | Re: custom function for converting human readable sizes to bytes |
| Previous Message | Pavel Stehule | 2016-01-04 17:24:35 | Re: custom function for converting human readable sizes to bytes |