two_phase commit parameter used in subscription for a publication which is on < 15.

From: tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: two_phase commit parameter used in subscription for a publication which is on < 15.
Date: 2021-09-27 07:09:51
Message-ID: CAC6VRoY3SAFeO7kZ0EOVC6mX=1ZyTocaecTDTh209W20KCC_aQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Please refer to this scenario
CASE 1- HEAD (publication)-> HEAD (Subscription)
CASE 2 - PG 14 (Publication) ->HEAD (Subscription)

Test-case -
Publication = create table t(n int); create publication p for table t;
Subscription = create table t(n int);
create subscription s connection 'dbname=postgres host=localhost '
PUBLICATION p WITH (two_phase=1);

Result-
CASE 1-
postgres=# select two_phase from pg_replication_slots where slot_name='s';
two_phase
-----------
t
(1 row)

CASE 2 -
postgres=# select two_phase from pg_replication_slots where slot_name='s';
two_phase
-----------
f
(1 row)

so are we silently ignoring this parameter as it is not supported on v14 ?
and if yes then why not we just throw a message like
ERROR: unrecognized subscription parameter: "two_phase"

--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message tushar 2021-09-27 07:11:14 Re: extensible options syntax for replication parser?
Previous Message Dilip Kumar 2021-09-27 06:53:23 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints