| From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
|---|---|
| To: | Victor Spirin <v(dot)spirin(at)postgrespro(dot)ru> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Atomic rename feature for Windows. |
| Date: | 2021-09-23 11:18:21 |
| Message-ID: | CAC+AXB3x=G=uK-ihBvws9JQzyOJRps8g-2QOcE5ZosBLzOLgNg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 7, 2021 at 11:40 PM Victor Spirin <v(dot)spirin(at)postgrespro(dot)ru>
wrote:
>
> I checked the pgrename_windows_posix_semantics() function on Windows 7.
> It returns error 87: Parameter is incorrect. Hence, it is necessary to
> check the Windows version and call the old pgrename function for old
> Windows.
>
> The FILE_RENAME_FLAGs are available starting from Windows 10 Release id
1607, NTDDI_WIN10_RS1. The check should be using something like
IsWindowsVersionOrGreater(10, 0, 1607). Or you could test this
using RtlGetVersion(), loading it from ntdll infrastructure coming from
stat() patch [1], which doesn't need a manifest.
Regards,
Juan José Santamaría Flecha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2021-09-23 11:46:53 | Re: Atomic rename feature for Windows. |
| Previous Message | Ranier Vilela | 2021-09-23 11:17:31 | Re: Eval expression R/O once time (src/backend/executor/execExpr.c) |