From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
---|---|
To: | Dmitry Igrishin <dmitigr(at)gmail(dot)com> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Small patch to fix build on Windows |
Date: | 2019-08-07 12:33:28 |
Message-ID: | CAC+AXB3v52LiNSjZ5TbRwsxGshVsYmokUzfNwnzFXtLf4UHd2Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Aug 7, 2019 at 11:11 AM Dmitry Igrishin <dmitigr(at)gmail(dot)com> wrote:
>
> ср, 7 авг. 2019 г. в 11:29, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>:
> >
> > Solution.pm has the following line:
> >
> > > my $opensslcmd =
> > > $self->{options}->{openssl} . "\\bin\\openssl.exe version 2>&1";
> >
> > AFAICS that's all.
> Thank you! The attached 2nd version of the patch fixes this too.
>
At some point the propossed patch for opensslcmd was like:
+ my $opensslprog = '\bin\openssl.exe version 2>&1';
+ my $opensslcmd = '"' . $self->{options}->{openssl} . '"' . $opensslprog;
It can be a question of taste, but I think the dot is easier to read.
Regards,
Juan José Santamaría Flecha
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2019-08-07 12:35:54 | initdb: Use varargs macro for PG_CMD_PRINTF |
Previous Message | Heikki Linnakangas | 2019-08-07 12:17:02 | Re: Grouping isolationtester tests in the schedule |