From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: A micro-optimisation for walkdir() |
Date: | 2020-09-04 20:34:17 |
Message-ID: | CAC+AXB3r7B5xEfscvniyYd_wUi-MAA8hLfOJtBS5rCsiktB_Eg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Sep 4, 2020 at 10:28 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:
> On 2020-Sep-04, Juan José Santamaría Flecha wrote:
>
> > On Fri, Sep 4, 2020 at 9:37 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
> > wrote:
> >
> > > On 2020-Sep-04, Thomas Munro wrote:
>
> > > >
> > > > +/* File types for 'd_type'. */
> > > > +enum
> > > > + {
> > > > + DT_UNKNOWN = 0,
> > > > +# define DT_UNKNOWN DT_UNKNOWN
> > >
> > > Uhm ... what do these #defines do? They look a bit funny.
> > >
> > > Would it make sense to give this enum a name, and then use that name in
> > > struct dirent's definition, instead of unsigned char?
> >
> > They mimic POSIX dirent.h. I would rather stick to that.
>
> Ah ... they do?
>
> If you remove the #define lines, what happens to your patch?
>
If will fail to detect that the patch makes the optimisation available for
WIN32:
+#if defined(DT_UNKNOWN) && defined(DT_REG) && defined(DT_DIR) &&
defined(DT_LNK)
Regards,
Juan José Santamaría Flecha
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2020-09-04 20:36:55 | Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path |
Previous Message | Alvaro Herrera | 2020-09-04 20:28:49 | Re: A micro-optimisation for walkdir() |