Re: PG compilation error with Visual Studio 2015/2017/2019

From: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
To: davinder singh <davindersingh2692(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG compilation error with Visual Studio 2015/2017/2019
Date: 2020-04-06 14:47:17
Message-ID: CAC+AXB3XvPekJ2c_X2jG6y+zyRkcaDxVBW2=rVyRLbGZOz8qpg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 6, 2020 at 1:08 PM davinder singh <davindersingh2692(at)gmail(dot)com>
wrote:

>
> I am working on “pg_locale compilation error with Visual Studio 2017”,
> Related threads[1],[2].
> We are getting compilation error in static char *IsoLocaleName(const char
> *winlocname) function in pg_locale.c file. This function is trying to
> convert the locale name into the Unix style. For example, it will change
> the locale name "en-US" into "en_US".
>

How do you reproduce this issue with Visual Studio? I see there is an ifdef
directive above IsoLocaleName():

#if defined(WIN32) && defined(LC_MESSAGES)

I would expect defined(LC_MESSAGES) to be false in MSVC.

Regards,

Juan José Santamaría Flecha

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Malek 2020-04-06 14:59:47 Re: bad wal on replica / incorrect resource manager data checksum in record / zfs
Previous Message Stephen Frost 2020-04-06 14:45:12 Re: where should I stick that backup?