Re: Can we get rid of GetLocaleInfoEx() yet?

From: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Can we get rid of GetLocaleInfoEx() yet?
Date: 2020-03-29 08:36:32
Message-ID: CAC+AXB2xJiYDHDZX01DNchQ0nu4XcQcOX7MHPdAijEaJVhG8DA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Mar 29, 2020 at 3:29 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

>
> The reason for the hack, per the comments, is that VS2015
> omits a codepage field from the result of _create_locale();
> and some optimism is expressed therein that Microsoft might
> undo that oversight in future. Has this been fixed in more
> recent VS versions? If not, can we find another, more robust
> way to do it?
>

While working on another issue I have seen this issue reproduce in VS2019.
So no, it has not been fixed.

Please find attached a patch that provides a better detection of the "uft8"
cases.

Regards,

Juan José Santamaría Flecha

Attachment Content-Type Size
0001_fix_win32_langinfo_uft8_detection.patch application/octet-stream 878 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2020-03-29 09:22:25 Re: PATCH: add support for IN and @> in functional-dependency statistics use
Previous Message Julien Rouhaud 2020-03-29 08:13:58 Re: pg_stat_statements issue with parallel maintenance (Was Re: WAL usage calculation patch)