Re: Meson add host_system to PG_VERSION_STR

From: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Meson add host_system to PG_VERSION_STR
Date: 2022-11-16 13:12:05
Message-ID: CAC+AXB2uzxDPxZ0EO9jXfiU3YxUrAVJaQY01YmKVct2q1gg38Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 16, 2022 at 10:50 AM Peter Eisentraut <
peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:

> On 16.11.22 01:01, Michael Paquier wrote:
> >
> > The meson build provides extra_version, which would be able to do the
> > same, no? The information would be appended to PG_VERSION_STR through
> > PG_VERSION.
>
> I think this is meant to achieve parity between the version strings
> generated by configure and by meson.
>
> Perhaps some examples before and after on different platforms could be
> shown.
>

Yes, that would make clear what the patch is trying to do. For version() we
get:

Configure:
PostgreSQL 16devel on x86_64-pc-linux-gnu, compiled by gcc (Debian
6.3.0-18+deb9u1) 6.3.0 20170516, 64-bit

Meson:
PostgreSQL 16devel on x86_64, compiled by gcc-6.3.0

Patched:
PostgreSQL 16devel on x86_64-linux, compiled by gcc-6.3.0

Regards,

Juan José Santamaría Flecha

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Maxim Orlov 2022-11-16 13:24:51 Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures
Previous Message Ian Lawrence Barwick 2022-11-16 13:00:35 Re: Commit fest 2022-11