| From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
|---|---|
| To: | Emil Iggland <emil(at)iggland(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #15858: could not stat file - over 4GB |
| Date: | 2020-02-28 09:15:45 |
| Message-ID: | CAC+AXB1woenhGpZuknntUPvgjK5KAnhjVjoVn-PnTGVXkM1tDw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Wed, Feb 5, 2020 at 12:47 PM Emil Iggland <emil(at)iggland(dot)com> wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: not tested
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation: not tested
>
The latest version of this patch could benefit from an update. Please find
attached a new version.
Most changes are cosmetic, but they have been more extensive than a simple
rebase so I am changing the status back to 'needs review'.
To summarize those changes:
- Rename 'win32_stat.c' file to 'win32stat.c', as a better match of
project files.
- Improve indentation and comments.
- Remove cruft about old Windows versions.
Regards,
Juan José Santamaría Flecha
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Support-for-large-files-on-Win32-v5.patch | application/octet-stream | 11.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Serbin, Ilya | 2020-02-28 09:25:22 | Re: BUG #16280: dead tuples (probably) effect plan and query performance |
| Previous Message | PG Bug reporting form | 2020-02-28 08:00:33 | BUG #16282: Avoid sql-injections at identifiers |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | legrand legrand | 2020-02-28 09:23:25 | Re: Implementing Incremental View Maintenance |
| Previous Message | Peter Eisentraut | 2020-02-28 09:02:40 | Re: base backup client as auxiliary backend process |