Re: OpenSSL conflicts with wincrypt.h

From: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: OpenSSL conflicts with wincrypt.h
Date: 2022-02-15 13:12:47
Message-ID: CAC+AXB19LnMDPA+KDiGjf=fYHgbRj2G4ays_ZfSBg7f43dR-vQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 11, 2022 at 4:36 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> =?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= <
> juanjo(dot)santamaria(at)gmail(dot)com> writes:
> > There is a comment in 'src/backend/libpq/be-secure-openssl.c' addressing
> > this issue, but I have to explicitly undefine X509_NAME. Please find
> > attached a patch for so.
>
> Um ... why? Shouldn't the #undef in the OpenSSL headers take care
> of the problem?
>
> After <openssl/ossl_typ.h> has been included, any inclusion of
<wincrypt.h> will be troublesome. There is already something similar in
'contrib/sslinfo/sslinfo.c'. This shouldn't be a problem while
defining WIN32_LEAN_AND_MEAN, but kerberos is directly including
<wincrypt.h> in <win-mac.h>.

Regards,

Juan José Santamaría Flecha

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeevan Ladhe 2022-02-15 13:18:41 Re: refactoring basebackup.c
Previous Message Filipe Rosset 2022-02-15 13:00:45 Re: How did queensnake corrupt zic.o?