| From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Ryan Lambert <ryan(at)rustprooflabs(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Anthony Nowocien <anowocien(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Filip Rembiałkowski <filip(dot)rembialkowski(at)gmail(dot)com> |
| Subject: | Re: dropdb --force |
| Date: | 2019-11-29 08:05:51 |
| Message-ID: | CAC+AXB0i88wj3OjsU7kXP3R8W45mt-CN53KZWEkdt3ht8naDFg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 29, 2019 at 7:30 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Thu, Nov 28, 2019 at 08:53:56AM +0530, Amit Kapila wrote:
> > I have pushed the refactoring patch. In the second patch, I have a
> > few more comments. I am not completely sure if it is a good idea to
> > write a new test file 060_dropdb_force.pl when we already have an
> > existing file 050_dropdb.pl for dropdb tests, but I think if we want
> > to do that, then lets move existing test for dropdb '-f' from
> > 050_dropdb.pl to new file and it might be better to name new file as
> > 051_dropdb_force.pl. I see that in some other cases like vacuumdb and
> > clusterdb, we have separate test files to cover a different kinds of
> > scenarios, so it should be okay to have a new file for dropdb tests.
>
> Amit, as most of the patch set has been committed, would it make sense
> to mark this entry as committed in the CF app?
>
>
Test 051_dropdb_force.pl is failing on Windows critters in the build farm,
e.g:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=drongo&dt=2019-11-29%2003%3A54%3A06
Regards,
Juan José Santamaría Flecha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Artur Zakirov | 2019-11-29 08:07:13 | Re: pg_upgrade fails with non-standard ACL |
| Previous Message | Fabien COELHO | 2019-11-29 07:44:25 | Re: fe-utils - share query cancellation code |