| From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Compile using the Visual Studio 2019 |
| Date: | 2019-05-21 06:38:42 |
| Message-ID: | CAC+AXB0TEzNPbSVuizGMt_BT_nHdchF7EQfisnGbKWC8JTb9Lw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 21, 2019 at 7:36 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, May 21, 2019 at 02:37:10PM +1200, David Rowley wrote:
> > Maybe you could take a look at that and maybe sign up to review it?
>
> Yes, that would be great. New VS environments are a pain to set up so
> any input is welcome.
>
>
At some point I did check, but that previous work went unnoticed. Now that
I have a better knowledge about building on Windows I will take a look at
it.
>
> I have not checked the other patch and I am pretty sure that you are
> doing the same thing. Still, for the notice, this comment update is
> incorrect as VS 2017 also marks nmake with version 15.
>
>
I don't want to keep this thread going any further, so I will check the
other patch and see how it goes through this point.
Regards,
Juan José Santamaría Flecha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2019-05-21 07:00:25 | Re: VACUUM fails to parse 0 and 1 as boolean value |
| Previous Message | Surafel Temesgen | 2019-05-21 06:31:48 | with oids option not removed in pg_dumpall |