Re: PG compilation error with Visual Studio 2015/2017/2019

From: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, davinder singh <davindersingh2692(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG compilation error with Visual Studio 2015/2017/2019
Date: 2020-05-06 17:30:50
Message-ID: CAC+AXB0NtOqy7hLiVFh0MtMoyD-xRo9stRdRUZgqyhY1ai_N7A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 6, 2020 at 6:41 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:

> On Wed, May 6, 2020 at 4:19 AM Juan José Santamaría Flecha
> >
> > I think that the definition of get_iso_localename() should be consistent
> across all versions, that is HEAD like back-patched.
> >
>
> Fair enough. I have changed such that get_iso_localename is the same
> in HEAD as it is backbranch patches. I have attached backbranch
> patches for the ease of verification.
>

LGTM, and I see no regression in the manual SQL tests, so no further
comments from my part.

Regards,

Juan José Santamaría Flecha

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeremy Schneider 2020-05-06 17:51:59 Re: SEQUENCE values (duplicated) in some corner cases when crash happens
Previous Message Victor Wagner 2020-05-06 17:14:22 Re: Postgres Windows build system doesn't work with python installed in Program Files